search

jkitchin / org-ref-cite

An org-cite processor that is like org-ref.
42 stars 6 forks source link

lazy load some features #26

Closed tshu-w closed 2 years ago

tshu-w commented 3 years ago

Hi, thank you for such an awesome package, can't wait for it going on MELPA. Though org 9.5 has been released, it can be considered 😄

After a brief try, I have a suggestion if we can speed up (require 'org-ref-cite) by lazy loading. While I know I could just require parts of it, I think lazy loading features would make it easier for newbies to use.

For example:

  1. we shouldn't (require 'org-ref) if the user didn't need it. (benchmark-run (require 'org-ref-cite-compat)) ;; (2.06666 0 0.0)
  2. ivy-set-display-transformer and other non-defined settings
jkitchin commented 3 years ago

Thanks for the suggestion. I moved the require inside the function, which should make it not load unless you call the function.