search

jkitchin / org-ref

org-mode modules for citations, cross-references, bibliographies in org-mode and useful bibtex tools to go with it.
GNU General Public License v3.0
1.35k stars 242 forks source link

A typo in org-ref-citation-links #1100

Closed 101scholar closed 7 months ago

101scholar commented 7 months ago

I think it should be let* instead of let because function bibtex-completion-find-pdf will use variable bibtex-completion-bibliograph. Otherwise, if org-ref uses a different bib file from bibTeX-completion, a warning of "Bibtex-completion couldn't find entry with key" will occur.

https://github.com/jkitchin/org-ref/blob/195b8d3209aff956ecdd755422700e8517a34d11/org-ref-citation-links.el#L595

jkitchin commented 7 months ago

I think you are right. I pushed a fix for this.