search

jkitchin / org-ref

org-mode modules for citations, cross-references, bibliographies in org-mode and useful bibtex tools to go with it.
GNU General Public License v3.0
1.37k stars 244 forks source link

Nothing found on call to isbn-to-bibtex #628

Closed non-Jedi closed 5 years ago

non-Jedi commented 5 years ago

Called isbn-to-bibtex with (isbn-to-bibtex "9780071422949" "/home/adam/org/references.bib") and got the "Nothing found" message despite everything on https://www.ottobib.com/isbn/9780071422949/bibtex looking perfectly valid.

Need to do more digging, but it seems like something on that page must be confounding the regex here: https://github.com/jkitchin/org-ref/blob/01d2fd7777563f78a5094209cfdf5918e7e45a3c/org-ref-isbn.el#L174

treese commented 5 years ago

Quick guess: the single quote in the citation key, which is just weird.

jkitchin commented 5 years ago

That single quote is unusual looking. It passes as a valid entry though, seems like it is ok in a link, and builds to a pdf via latex, so I guess it is legit. I will look into adding it to the regexp. Thanks for reporting it.

jkitchin commented 5 years ago

I am pretty sure this is fixed in 1f88739. Thanks for reporting it. A chemical engineering book at that!

non-Jedi commented 5 years ago

Thanks! :)