jkitchin / ox-ipynb

org-mode exporter to Jupyter notebooks
173 stars 40 forks source link

Text emphasis markers for code (tilde) do export differently for subtree headings and text blocks #33

Closed BBurkhardt closed 4 years ago

BBurkhardt commented 4 years ago

ℹ Computer information

📝 Reproduction steps

Export the following org code with emphasis markers to a notebook and open it (see attached file archive).

`* ~Code~

✔️ Expected result

Code

❌ Actual result

~Code~

code_emphasis.zip

BBurkhardt commented 4 years ago

Dear John,

thanks for the quick reaction. Your latest commit solves that problem for me.

May I ask why the list of external properties is necessary in the call of the org-export-string-as function? What does it do?

Another observation: while testing the updated version of ox-ipynb, I also tried to export underlined text in both subtree headings and text blocks:

`* Test

This was exported as follows:

`## Test

This is not rendered as underlined text in the juypter notebook. Instead could ox-ipynb be changed such that the export procedure returns the following:

`## Test

I'm not using underlining a whole lot myself, but it's avilable in org-mode so why not have it export nicely to notebooks. I understand that underlining via html tags may not be considered native markdown syntax, but since these html tags are rendered correctly in the notebooks, I would opt to support these emphasis markers.

Feel free to move this into another issue. I was not sure whether this is significant enough to warrant that. Thanks again for all your work to make this package available. I really appreciate it.

jkitchin commented 4 years ago

those external properties suppress the table of contents and tags. It is easy enough to change the underline markup. I just pushed a fix for that.

BBurkhardt commented 4 years ago

Thanks a bunch for your work! With these fixes in place the issue can be closed.