Closed whwang299 closed 4 years ago
Also,
TMP
in following code should change into DERIVED_TABLEalias0
with additional AS
?
https://github.com/jkkummerfeld/text2sql-data/blob/7aaae5bfcce37a54d1d713cabb27ee60dc9ba422/data/geography.json#L8004
Thanks for raising these! I won't be able to get to this until the weekend, but if you draft a Pull Request before then I'd be happy to review it.
I have made pull request (https://github.com/jkkummerfeld/text2sql-data/pull/42). Please review :).
Thanks!
Thanks! Merged. I've also pushed a general update to master with other improvements that were waiting in our data development branch.
Hi @jkkummerfeld
I think "(SELECT" in the code below should change into "( SELECT" for the consistency. https://github.com/jkkummerfeld/text2sql-data/blob/7aaae5bfcce37a54d1d713cabb27ee60dc9ba422/data/geography.json#L7666
Thanks for the great work.
Wonseok