search

jkkummerfeld / text2sql-data

A collection of datasets that pair questions with SQL queries.
http://jkk.name/text2sql-data/
Other
549 stars 106 forks source link

Spacing error(?) in geography.json #41

Closed whwang299 closed 5 years ago

whwang299 commented 5 years ago

Hi @jkkummerfeld

I think "(SELECT" in the code below should change into "( SELECT" for the consistency. https://github.com/jkkummerfeld/text2sql-data/blob/7aaae5bfcce37a54d1d713cabb27ee60dc9ba422/data/geography.json#L7666

Thanks for the great work.

Wonseok

whwang299 commented 5 years ago

Also, TMP in following code should change into DERIVED_TABLEalias0 with additional AS? https://github.com/jkkummerfeld/text2sql-data/blob/7aaae5bfcce37a54d1d713cabb27ee60dc9ba422/data/geography.json#L8004

jkkummerfeld commented 5 years ago

Thanks for raising these! I won't be able to get to this until the weekend, but if you draft a Pull Request before then I'd be happy to review it.

whwang299 commented 5 years ago

I have made pull request (https://github.com/jkkummerfeld/text2sql-data/pull/42). Please review :).

Thanks!

jkkummerfeld commented 5 years ago

Thanks! Merged. I've also pushed a general update to master with other improvements that were waiting in our data development branch.