jklepatch / eattheblocks

Source code for Eat The Blocks, a screencast for Ethereum Dapp Developers
https://eattheblocks.com
4k stars 3.2k forks source link

Uniswap Token.fetchData is not a function #99

Open wcDogg opened 3 years ago

wcDogg commented 3 years ago

This issue is for 'Profitable Flashloans' but it looks like it applies to other courses. I'm a tech writer with reasonable Python skills + a bit of JS and yet I have no friggin' clue what to do next. Anyone considering Eattheblocks courses should also be interested in this thread - How's the support? How explicit are course instructions? How well are the courses maintained?

Following the course instructions + the Uniswap V2 instructions, I installed npm install @uniswap/sdk.

The course uses fetchData which appears to be Uniswap V1.

Saw #53 and verified that some form of fetchTokenData and fetchPairData is for Uniswap V2

I thought I was using V2. When I couldn't get Fetcher to work, looked at package.json and see I have @uniswap/sdk ^3.0.3

I imagine this means I have Uniswap V3 which is weird because the install commands are totally different. Here's the V3 instructions:

Adding to my saga, I don't understand the V3 documentation at all - I see nothing about Fetch, and all of it looks very different from V2.

I need detailed, explicit instructions on what to do here, otherwise the course in unusable for me.

And clearly the courses need updating - the V1 instructions are completely outdated and the V2 - V3 straddle needs to be addressed.

TimothyHyland commented 3 years ago

a simple npm install in main directory of code will install all needed dependencies. You installed the newer version of Uniswap sdk which uses different code. Are you a student at Eattheblocks ? If you were you would have private discord and forum to ask questions in for faster response than this.

YakovKontarook commented 3 years ago

Hey did you solve this problem?

wcDogg commented 3 years ago

@Woodcreek - Apologies for delay - offline for a bit.

@TimothyHyland -

Of course I'm a student - how else could I ask about specific course instructions?. No, I can't access the Discord. Maybe Discord doesn't like Brave browser? Don't know, don't care.

Even if I could access a private forum, I'd still be posting here. These are the public repos used in your courses. I came here to review my code (useless), so it's here I posted.

Eat the Blocks courses are expensive with few user reviews. And like it or not, you'll get questions here. How you answer says a lot

You could have said, "We're updating the videos, in the meantime, here's the Uniswap V3 repo link". That's the only acceptable reply here or on Discord.

Refund requested.

A final word about Teachable - they are not like Udemy or Lynda who handle billing and refunds. With Teachable you have to contact the 'school owner'.

TimothyHyland commented 3 years ago

@wcDogg

Great! Being a student at Eattheblocks, you would have received an onboarding email with all support links. Your preference of support venue is always your choice. I merely mentioned that Discord seems to be the faster turn around for answers.

Nkanyiso04 commented 3 years ago

I'm definitely going to join by tonight. I'd like to learn a lot of very interesting things actually. See you on discord

On Thu, 02 Sep 2021, 17:58 Tim Hyland, @.***> wrote:

@wcDogg https://github.com/wcDogg

Great! Being a student at Eattheblocks, you would have received an onboarding email with all support links. Your preference of support venue is always your choice. I merely mentioned that Discord seems to be the faster turn around for answers.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jklepatch/eattheblocks/issues/99#issuecomment-911833164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVOIYL2RSPKWTY2IXOFTFKTT76NJRANCNFSM5AMSDZKA .

felixsc1 commented 2 years ago

I bought the course in 2022. Guess it was a mistake.. uniswap V1 is totally outdated, I'll try to get it to work with V3 instead. @wcDogg did you finally solve it?

aagbotemi commented 2 years ago

Hi, @felixsc1, have you been able to solve this issue, I'm facing the same error