search

jklimke / libcitygml

C++ Library for CityGML Parsing and Visualization
GNU Lesser General Public License v2.1
98 stars 55 forks source link

Are ReliefFeatures not supported? #36

Open shehzan10 opened 7 years ago

shehzan10 commented 7 years ago

I've been working with a a couple of models from https://www.citygml.org/samplefiles/

Both of these models use ReliefFeature, but the CityObject for this returns 0 for both getGeometriesCount() and getImplicitGeometryCount(), and has 0 child city objects.

In FZK Viewer, the object tree for these files shows the relief:ReliefFeature as having a child relief:TINRelief object. This TINRelief object does not appear in the CityObject tree.

All the other features of the models seem to be working well. Am I missing something here?

shehzan10 commented 7 years ago

I verified from here that ReliefComponent is not supported.

I guess my next question is how hard would it be to support this? Understanding why it hasn't been implemented could help my efforts if I try to implement support for it.

jklimke commented 7 years ago

I guess it hasn't been implemented simply because it was not needed up to now.

This decision was taken before i took the library over to github. But feel free to give the implementation a try. Do not forget to add a small test dataset and a corresponding test.