search

jklimke / libcitygml

C++ Library for CityGML Parsing and Visualization
GNU Lesser General Public License v2.1
98 stars 55 forks source link

Make libcitygml prebuilds portable #98

Open gostefan opened 3 months ago

gostefan commented 3 months ago

The current state of the CMakeLists.txt doesn't allow libcitygml to be prebuilt and deployed on different machines or to different paths. With some simple fixes we can enable this usecase.

This PR is only about the last two commits - the three previous commits are part a different PR. But the changes would conflict if not based on each other. If I should rather modify this PR to only include the last two commits, please let me know.

gostefan commented 3 months ago

I just realized that now the citygml.pc file doesn't get installed correctly anymore. I'll fix that but probably it'll take me some time.

Ok... I realized that it's much easier than I thought - already pushed the new version.

gostefan commented 1 month ago

The first commit introduced a regression on linux. The CMake files weren't installed in the lib folder anymore. This was because an include was missing and is fixed now.

gostefan commented 1 month ago

Trying to use the built project on Linux made me realize that the cmake files still had some absolute paths in them. Fixed now.