search

jklmli / manga_downloader

Cross-platform, multi-site, multi-threaded manga downloader with over 5000 distinct mangas. Includes support for automated downloading via external .xml file and conversion for viewing on the Kindle.
MIT License
270 stars 53 forks source link

MangaFox Fails to Download manga with Spaces #18

Closed spikepmw closed 13 years ago

spikepmw commented 13 years ago

The following modification to fixformatting found in util.py has caused manga names with spaces to fail when downloading from MangaFox.

Modification: return s.lower().lstrip('.').strip().replace(' ', '_') -> return s.lower().lstrip('.').strip().replace(' ', '.')

Ex python manga.py "Nurahiyon no mago"

Followed by the selection for manga fox will fail.

jklmli commented 13 years ago

I think you may have spelled "nurarihyon no mago" incorrectly.
http://www.mangafox.com/search.php?name_method=bw&name=nurahiyon+no+mago returns no results

The only time I use fixFormatting with respect to searching on the MangaFox parser is to do an early 'direct search' if the user spelled everything correctly. Granted this was broken, and I have since fixed it in the latest commit. But strings are immutable, so this direct search should not have had an impact on the follow-up selection.

spikepmw commented 13 years ago

I did misspell the name; however, there was an issue in Manga Fox. However it appears looking at your commits you fixed the issue.