fix(try): pass error into matcher

[mrmurphy]

fix(try): pass error into matcher

Pass a Try's error into the Failed case on a match.

Closes https://github.com/jiaweihli/monapt/issues/15.

[jklmli]

Looks good - I missed this during the 1.0 migration. I'll also add some tests for this later.

Can you format your commit message in conventional style? e.g. fix(try): pass error into matcher. I'm trying out another tool, semantic-release, that automatically parses commit messages and generates a changelog/release/npm version. It'd be neat to see if it works out end-to-end.

[mrmurphy]

Sure thing!

[jklmli]

Sorry, that was unclear. I meant the commit itself (via git commit --amend, then update the PR with git push -f origin) rather than the PR description.

Also, can you remove the BREAKING CHANGE? That'll unfortunately cause a major version bump to 2.0.0.

If this is too much trouble, let me know. The last thing I want is for PRs to be tedious. I'm working on integrating tooling to help automate all of this.

[mrmurphy]

Oh okay! No that'll be fine 😊. I'll just have to do it late tonight or tomorrow when I'm not only on my phone.

[jklmli]

No problem - thanks for working through this with me. 👍

Happy to hear you're getting value out of monapt!

[mrmurphy]

No problem! Thanks for being quick to respond. I've updated the commit message now and taken out the BREAKING CHANGE line.

[coveralls]

Coverage remained the same at 98.81% when pulling dff5b6150bfa99579d502e712b10644644ac0ac2 on bloom:master into ec12411367aace75eb37c0af779ae5e0eb6a5fed on jiaweihli:master.

[jklmli]

Perfect, landed on npm and released with a changelog.

[mrmurphy]

Also, sorry I didn't add a test for this. I'd like to be better at that in the future. 😅

[jklmli]

No worries - tests are very much appreciated but I know they're time-consuming to write.

Looks like I need to tweak the code coverage though... 😛