search

jknaresh / gwtupload

Automatically exported from code.google.com/p/gwtupload
Other
0 stars 0 forks source link

uploader.setSizeMax(maxSize) is not sufficient #198

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

uploader.setSizeMax(maxSize) is not sufficient in 
gwtupload.server.UploadServlet.java. Testing Content-Length is not sufficient 
too.
Something like
uploader.setFileSizeMax(maxFileSize)
should be added.

org.apache.commons.fileupload.FileUploadBase.FileItemStreamImpl counts bytes 
only if fileSizeMax != -1, the default.

Regards

Michael

Original issue reported on code.google.com by kn...@stepover.de on 26 Apr 2014 at 2:28

GoogleCodeExporter commented 9 years ago 
Can you propose a patch for this?

Original comment by manuel.carrasco.m on 27 Apr 2014 at 6:47

GoogleCodeExporter commented 9 years ago 
Please find patches attached.

Original comment by kn...@stepover.de on 28 Apr 2014 at 9:45

Attachments:

GoogleCodeExporter commented 9 years ago 
Are patches sufficient?

Original comment by kn...@stepover.de on 5 Jun 2014 at 2:02

GoogleCodeExporter commented 9 years ago 
Applied your patch.

Thanks for Contributing.

Original comment by manuel.carrasco.m on 7 Jan 2015 at 5:28

GoogleCodeExporter commented 9 years ago 
Can someone update the documentation for this? We struggled for a long time to 
find that the parameter name had changed.

Thanks!

Original comment by sh...@tarves.net on 3 Mar 2015 at 7:33

GoogleCodeExporter commented 9 years ago 
Updated, thanks for reporting

https://code.google.com/p/gwtupload/wiki/GwtUpload_GettingStarted

Original comment by manuel.carrasco.m on 4 Mar 2015 at 9:31