search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Changes allow_overlapping_ips behavior. #101

Closed MattDietz closed 11 years ago

MattDietz commented 11 years ago

Resolves Issue #87 by changing the overlapping IPs behavior from system wide to within the boundaries of the subnets associated with the network.

asadoughi commented 11 years ago

LGTM

asadoughi commented 11 years ago

Hmm, ran krauq on this change and it failed on test_create_overlapping_subnets_fail. (overlapping subnet was created when it shouldn't have been). I'll have to look into it later.

asadoughi commented 11 years ago

Ah, nevermind, you switched the meaning of allow_overlapping_ips on me in my config. hehe

MattDietz commented 11 years ago

lulz, sorry about that.

On Tue, Jun 18, 2013 at 3:18 PM, Amir Sadoughi notifications@github.comwrote:

Ah, nevermind, you switched the meaning of allow_overlapping_ips on me in my config. hehe

— Reply to this email directly or view it on GitHubhttps://github.com/jkoelker/quark/pull/101#issuecomment-19639118 .