search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

break apart drivers/nvp_driver into separate classes #107

Closed jmeridth closed 11 years ago

jmeridth commented 11 years ago

should result in:

nvp_driver.py optimized_nvp_driver.py qos.py lswitch.py lswitchport.py

roaet commented 11 years ago

As much as I like this idea, I hate monolithic files as much as the next guy, this would begin a precedent that could cause an explosion at the file factory (see models.py). It may not necessarily increase readability in certain situations.

I absolutely agree nvp_driver and optimized_nvp_driver should be separate but maybe the tables (that are only meaningful to the optimized driver) could stay with it? I'd rather the effort to increase readability be focused on the big files (plugin.py) than the specialized smaller ones.

Two cents.

jmeridth commented 11 years ago

That's sounds good to me. I'm actually looking at that right now. I'll leave the switch and qos classes in the optimized driver file.

asadoughi commented 11 years ago

Fix with pull #108