jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

split nvp_driver and optimize_nvp_driver classes #108

Closed jmeridth closed 11 years ago

jmeridth commented 11 years ago
asadoughi commented 11 years ago

LGTM. Waiting for travis-ci to merge.

roaet commented 11 years ago

I have concerns that this will dunk stones' PR.

jmeridth commented 11 years ago

This fixes Issue #107

jmeridth commented 11 years ago

roaet: that was a concern, dietz and stones said to go forward.

roaet commented 11 years ago

If they said it was good then LGTM. But uh. what's with travis?

asadoughi commented 11 years ago

Le flake8 fail for travis-ci. @jmeridth, please run tox before creating a pull request to run the unit tests and flake8. pip install tox; tox