search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Fixed multiple db_api errors and resolved task 977 #111

Closed roaet closed 11 years ago

roaet commented 11 years ago

Task 977 required a special case for the route collision if the other route was the default route (0.0.0.0/0).

The db_api errors was the lack of the scope parameter for most of the route calls.

roaet commented 11 years ago

My flake8 is broken. Please wait before PR.

roaet commented 11 years ago

Alright. tox passed.

MattDietz commented 11 years ago

Merge conflict after Stones' patch

roaet commented 11 years ago

I'll fix the conflicts. Damn you stooooooones.

roaet commented 11 years ago

Tox werkz.

roaet commented 11 years ago

Used DEFAULT_ROUTE as per @asadoughi

asadoughi commented 11 years ago

LGTM, waiting for travis-ci. It's good that you used IPNetwork.value because that makes it version-agnostic.

>>> a = netaddr.IPNetwork("0.0.0.0/0")
>>> b = netaddr.IPNetwork("::/0")
>>> a == b
False
>>> a.value == b.value
True
>>> c = netaddr.IPNetwork("0.0.0.0/0")
>>> a == c
True

We probably have that bug in a couple of other places.