search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Clean up around some of the new code plus tests #129

Closed MattDietz closed 11 years ago

MattDietz commented 11 years ago

Adds some more tests to the plugin for coverage purposes and missed edge cases, adds new defensive input handling in security group rule creation, and other random cleanup.

MattDietz commented 11 years ago

I don't know why, but your comments aren't showing up in the code, which is super annoying. :-/

MattDietz commented 11 years ago

Alright, double checked in the security groups extension and removed the superfluous code and tests.

kilogram commented 11 years ago

My bad, I think I was actually in the diff on your branch and not on the PR diff. I don't know why they're separate, but okay.

kilogram commented 11 years ago

yaaaaaay thanks for cleaning up my code.