search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Ports submod #137

Closed MattDietz closed 11 years ago

jmeridth commented 11 years ago

Test count dropped from 247 to 234

MattDietz commented 11 years ago

Seems odd. I'll look into it tomorrow morning. I don't recall deleting any...

On Jul 23, 2013, at 10:55 PM, Jason Meridth notifications@github.com wrote:

Test count dropped from 247 to 234

— Reply to this email directly or view it on GitHub.

jmeridth commented 11 years ago

want me to wait to merge the others?

MattDietz commented 11 years ago

plz

jmeridth commented 11 years ago

I will research what changed. Happy hunting. :smile:

MattDietz commented 11 years ago

Figured it out: https://github.com/jkoelker/quark/pull/135/files

Somehow I didn't end up removing the tests when I copied them into the separate test_ip_addresses.py and instead they got removed in this patch. So I know what happened, though I don't recall doing that at all. Very weird.

jmeridth commented 11 years ago

Good catch On Jul 23, 2013 11:20 PM, "Matt Dietz" notifications@github.com wrote:

Figured it out: https://github.com/jkoelker/quark/pull/135/files

Somehow I didn't end up removing the tests when I copied them into the separate test_ip_addresses.py and instead they got removed in this patch. So I know what happened, though I don't recall doing that at all. Very weird.

— Reply to this email directly or view it on GitHubhttps://github.com/jkoelker/quark/pull/137#issuecomment-21462909 .

MattDietz commented 11 years ago

And confirmed that master pre-all these patches was 234 tests.

Ran 234 tests in 5.570s

jmeridth commented 11 years ago

You are correct. It went to 247 while on your ip_addresses_submod. Then dropped back to 234 once merged. Weird.

jmeridth commented 11 years ago

Continuing with the merging of the other pull requests