Implemented quark notifications (w/ unit tests)

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark

Apache License 2.0

0 stars 2 forks source link

Implemented quark notifications (w/ unit tests) #156

Closed asadoughi closed 11 years ago

asadoughi commented 11 years ago

Notifications published on subnet creation/deletion and IP address creation and deallocation.

asadoughi commented 11 years ago

I thought about making the code more clean by abstracting into a decorator around the db/api functions, but I decided against abstraction when there are only 4 instances of notification.

roaet commented 11 years ago

LGTM. moar reviwers plox

jmeridth commented 11 years ago

lgtm including my nitpicking :+1:

Will merge if you don't want to make any changes.

asadoughi commented 11 years ago

I'll make changes, just not until tomorrow morning.

asadoughi commented 11 years ago

I didn't properly read your comments last night and see now that I won't make changes if my responses to your comments are sufficient.

jmeridth commented 11 years ago

LTGM