search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Fix for circular reference error #49

Closed asadoughi closed 11 years ago

asadoughi commented 11 years ago

On create_subnet, the quantum client passes in arguments to create a subnet with, including dns_nameservers and allocation_pools, which do not exist in quark's database models. SQLAlchemy causes these fields to exist in the model created and result as basic objects in the response object, which in turn is choked upon by oslo-incubator's jsonutils.to_primitive function.

jkoelker commented 11 years ago

LGTM, small perf improvement you can do d.pop(k, None) and it will default to None if the key doesn't exist so don't nee the if.

jkoelker commented 11 years ago

Github really need a comment and merge button ;)