search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Implements a first cut of network strategies #60

Closed MattDietz closed 11 years ago

MattDietz commented 11 years ago

Implements the basic network strategy driver. The aim of this patch is to provide a conceptually similar implement of both provider networks and melange default networks while adding additional flexibility. One of the other aims of this patch is to attempt to coerce a truer version of shared networks out of the quantum implementation as it exists today.

Still considered a work in progress.

MattDietz commented 11 years ago

I think it does belong there, actually

MattDietz commented 11 years ago

Don't merge this yet. Found a pretty heinous bug

MattDietz commented 11 years ago

Think I fixed the bug, so feel free

asadoughi commented 11 years ago

Sorry for being review nazi :)

MattDietz commented 11 years ago

No worries. Better if you try to get it all together at the same time though. That change is fine

:punch:

MattDietz commented 11 years ago

Well I can't do anything about that build failure.

asadoughi commented 11 years ago

Is it possible to git push -f with no changes to reload the branch and thus travis-ci?

jkoelker commented 11 years ago

you can just goto travis and click retry build

On Tue, May 7, 2013 at 11:05 AM, Amir notifications@github.com wrote:

Is it possible to git push -f with no changes to reload the branch and thus travis-ci?

— Reply to this email directly or view it on GitHubhttps://github.com/jkoelker/quark/pull/60#issuecomment-17551890 .

asadoughi commented 11 years ago

I cannot -- It's disabled. http://i.imgur.com/nvXXoDK.png

asadoughi commented 11 years ago

Ah, nevermind, wasn't logged in, build restarted.

asadoughi commented 11 years ago

LGTM. (Unit tests for db_api.network_find and the strategy class would be nice since they're non-trivial.)

jkoelker commented 11 years ago

Merging, we can tie up loose ends laters.