search

jkoelker / quark

This is my fork, Quark is now at https://github.com/rackerlabs/quark
Apache License 2.0
0 stars 2 forks source link

Optimized switch cloning #99

Closed MattDietz closed 11 years ago

MattDietz commented 11 years ago

Implements switch spanning for the optimized driver and adds a couple columns to the nvp lswitch table for the clone details lookup.

asadoughi commented 11 years ago

I don't see my typo fix: s/piece/peace/

MattDietz commented 11 years ago

Meh

asadoughi commented 11 years ago

I see LSwitch.display_name added. This might require bouncing the database upon deploy. Is there a second field?; your commit message mentions two.

Also, have we considered separating out the non-optimized vs. optimized driver into separate .py files? This would make reviewing easier.

EDIT: also, db models in a third, separate .py would be nice methinks.

MattDietz commented 11 years ago

I conflated the columns added in the unop path with the optimized driver path. I can change the commit message if you want, but it seems trite to me.

And yes, we need to bounce the database to use the optimized driver properly. As the behavior of the unoptimized driver is to copy all switch attributes for a given network, we need to be able to store all the necessary and relevant bits in the database to emulate what we've done there.

I agree with the idea of pulling everything out into their constituent modules. Is that something you want to look at? I'm planning to help with instance boots and tackle the rest of the net strategy stuff next.

asadoughi commented 11 years ago

Perhaps something for @kilogram to look at since he's modifying those files now in #92. I wouldn't want to create a massive merge conflict for him.

asadoughi commented 11 years ago

OK. We'll do the file split after this and #92 (or, rather it's reincarnation) get merged. Meanwhile, this PR has merge conflicts.

MattDietz commented 11 years ago

resolved. Also I need to fix my damn ntp on my vm again