jkomoros / boardgame

An in-progress framework in golang to easily build boardgame Progressive Web Apps
Apache License 2.0
31 stars 4 forks source link

Make sure all example games follow all best practices #309

Open jkomoros opened 7 years ago

jkomoros commented 7 years ago

E.g use DefaultMove, all naming schemes, what's public and private

jkomoros commented 7 years ago
jkomoros commented 7 years ago

Related: heavily comment the examples so that they can be used like a tutorial

jkomoros commented 7 years ago

MoveConstructor's constructor should have BaseMove be a named argument so that the other values can be omitted, e.g.

    MoveConstructor: func(mType *boardgame.MoveType) boardgame.Move {
        return &MoveActivateHandmaid{
            BaseMove: boardgame.BaseMove{mType},
        }
    },