search

jkomoros / boardgame

An in-progress framework in golang to easily build boardgame Progressive Web Apps
Apache License 2.0
31 stars 4 forks source link

Get rid of moves.NoOp? #647

Open jkomoros opened 6 years ago

jkomoros commented 6 years ago

It says it's for duplicates in a row, but doing that would require you to pass two different move objects with the same name in, which is illegal. So the case it guards against doesn't happen except in unit tests.

If we remove, remove it from Tutorial.MD as well

Was added in #627 but might not be necessary.

jkomoros commented 6 years ago

NoOp might be useful in other cases, though, for example in #645

jkomoros commented 6 years ago

boardgame-util stub also uses it in the minimal case