Clean up cloud functions implementation

jkomoros / card-web

The web app behind thecompendium.cards

Apache License 2.0

46 stars 8 forks source link

Open jkomoros opened 4 years ago

jkomoros commented 4 years ago

Especially with #212, it's gotten really messy.

Note that #134 is also covered in this.

jkomoros commented 4 years ago

[x] Update to node 10 (https://firebase.google.com/docs/functions/manage-functions#set_nodejs_version)
[ ] Remove fromEntries npm package and switch from reduce() to flat() in the pickCardToTweet
[ ] have only one copy of tweet-helpers.js (the webapp can reach out into the functions package easily if it's written in ES6 style modules)

jkomoros commented 4 years ago

Maybe it's just a matter of adopting typescript for the functions, because the transpilation makes it trivial for it to support the different types of imports (?) https://firebase.googleblog.com/2018/01/why-you-should-use-typescript-for.html