jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
46 stars 8 forks source link

Use smaller Firestore imports #528

Closed jkomoros closed 2 years ago

jkomoros commented 3 years ago

https://firebase.googleblog.com/2021/07/introducing-the-new-firebase-js-sdk.html

jkomoros commented 2 years ago

https://firebase.googleblog.com/2021/08/deep-dive-into-the-new-firebase-js-sdk-design.html

jkomoros commented 2 years ago

https://firebase.google.com/docs/web/modular-upgrade

jkomoros commented 2 years ago

This might not be possible with polymer-cli? How to upgrade from it?

jkomoros commented 2 years ago
jkomoros commented 2 years ago

Oh goodie, the same error message (Uncaught SyntaxError: The requested module './../../../../../app/dist/index.esm.js' does not provide an export named 'SDK_VERSION' (at index.esm2017.js:1:93)) is showing up even after moving to rollup build...

jkomoros commented 2 years ago

There's likely something going on about bare module specifiers and the way they're handled in both lit / rollup : https://lit.dev/docs/v1/tools/build/#bare-module-specifiers, leading to the bare module specifiers in the firebase packages being rewritten to incorrect versions of themselves somehow?

jkomoros commented 2 years ago

https://firebase.google.com/docs/web/module-bundling

jkomoros commented 2 years ago
jkomoros commented 2 years ago

Being developed in firebase-modular branch

jkomoros commented 2 years ago

Tests are having the compat import problem. https://github.com/firebase/firebase-js-sdk/issues/5687 seems vaguely related?