jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
53 stars 8 forks source link

Consider making renderOffset in card-thumbnail-list not be an exposed property #552

Open jkomoros opened 2 years ago

jkomoros commented 2 years ago

It's a bit weird that we have the renderOffset stored in canonical state. Conceptually, maybe it makes sense to be entirely derived within the card-thumbnail-list, and not exposed elsewhere.

Also, right now, there SHOULD be a bug where if you ahve a card selected in your view, then manually hit the next/prev affordance, I would expect it to then snap BACK to where you were, because it would notice that the highlighted card is not in view and advance the offset until it is. But that's not what happens... why? Maybe if it's already been scrolled into view, it doesn't force a scroll, and that's why.

Related to #547