search

jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
46 stars 8 forks source link

Opening the find dialog on the very first card shows bad results #555

Closed jkomoros closed 2 years ago

jkomoros commented 2 years ago

Related to #545. The broken behavior of 545 obscured weird behavior.

The find dialog starts off showing similar cards to the current card by default. So if you're sitting on the "half baked section head" card, it show content like "What is this" etc.

Instead, if it's not a "find card to link", the query should be "recent cards" sort.

jkomoros commented 2 years ago

When you first load the app and open find, the cards in the find dialog are the "What is this" and other generic cards. The reason is that since #545 was fixed we load up the similar cards, but the similar cards to a section-head aren't sorted at all.

The effect is a bit weird since those cards are unlikely to actually be interesting.

Conceptually what we want is "sort first by similar, then sort by recently_updated", which blocks on #296.

But for now, the simplest fix is as described immediately above