jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
46 stars 8 forks source link

Re-enable firestore persistence with enableIndexedDbPersistence #597

Open jkomoros opened 2 years ago

jkomoros commented 2 years ago

Persistence was turned off in #528 , because enableIndexedDbPersistence 's promise was never being resolved or rejected when running in a browser where there had been persistence enabled with the v8 firestore.

It turns out to not be that big of a deal; even without persistence the cache updates happen as soon as the batch is committed, before the server fully acks, so the UI can update quickly.

Presumably this might make reloads of the app slower, but in practice it didn't seem like it make a big difference in the first place. Tracking just for completeness.