jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
46 stars 8 forks source link

Did functions deploy break? #637

Closed jkomoros closed 2 years ago

jkomoros commented 2 years ago

The deploy on 8/21/22 didn't work for the functions.

What also happened recently was a lot of dependabot bumps the day before. Perhaps that broke something?

jkomoros commented 2 years ago

Yeah those dependabot updates did break it. Doing bisect now (each test takes a minute or two...)

jkomoros commented 2 years ago

3d03d4d is good, 655f2f8 is bad

jkomoros commented 2 years ago

This bug means that the random-card deploy on 8/21/22 at ~3:30pm didn't actually deploy hosting

jkomoros commented 2 years ago

Bisect says 2d5452c1b974f88697b495b7aba343b051b23f01 is the problem, which updated firebase-admin from 8.9.2 to 11.0.1

jkomoros commented 2 years ago

https://firebase.google.com/docs/admin/migrate-node-v10