search

jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
46 stars 8 forks source link

lit-plugin erroneously warns about missing-import #676

Closed jkomoros closed 7 months ago

jkomoros commented 7 months ago

For example, when viewing src/components/card-view.ts, the lit-plugin warns 

Missing import for <card-drawer>
  You can disable this check by disabling the 'no-missing-import' rule.

Despite the fact the file imports ./card-drawer.js and it defines a customElement.

It's a bit hard to debug since there's a delay, but it SEEMS like settings.json exclude causes the problem:

    "files.exclude": {
        //....
        "src/**/*.js": true,
        //...
    },

We have that because of the non-standard typescript-adjacent-to-real-files setup, instead of having a lib/ like everyone else does.

jkomoros commented 7 months ago

No wait the missing imports don't appear to be fixed >:-(

jkomoros commented 7 months ago

Oh yeah it did fix it, I just needed to reopen VSCode

jkomoros commented 7 months ago

Hmm no it still does show up every so often, e.g. in card_diff.ts.

jkomoros commented 7 months ago

Perhaps this actually is a problem with the plugin, not my code? https://github.com/runem/lit-analyzer/issues/330