jkomoros / card-web

The web app behind thecompendium.cards
Apache License 2.0
46 stars 8 forks source link

Clean up naming around auto TODO overrides #689

Open jkomoros opened 3 months ago

jkomoros commented 3 months ago

The logic seems backwards for example we had to flip the labels in multi-edit-dialog, and in descriptionForCardDiff we have that backwards message for prioritized.

Is it possible the main naming is just backwards and then everything else has to be backwards too, in a confusing way?

Like, maybe the naming of the fields on CardDiff are backwards?

I think it's that the enablements and disablements fields in CardDiff are named backwards from what they should be, given the naming scheme for what the overrides mean on Card. And that leads to the confusing names for antyhing touching card diffs directly, like in multi-edit or descriptionForCardDiff.