search

jkomoros / sudoku

A sudoku puzzle solver, generator, and difficulty-rater built in Go
Apache License 2.0
5 stars 1 forks source link

Cull steps tell users to cull possibilities from filled cells unnecessarily #267

Open jkomoros opened 8 years ago

jkomoros commented 8 years ago

As long as one cell is unfilled and has a possibility removed, it tells you to remove them from ALL other cells in the group--even the filled ones.

Not a big deal, but makes the description of the step unnecessarily long.

jkomoros commented 8 years ago

This might also apply to almost all other cull techniques?

jkomoros commented 8 years ago

This change is purely cosmetic for hints, because SolveStep.IsUseful would only report a cull step as useful if at least one possibilty was culled from an unfilled cell in the group.

jkomoros commented 8 years ago

Changing this logic on a per-technique basis is actually pretty error prone. In a perfect world there would be a setter for TargetCells, or a SolveStep.Normalize() that's always called, that would cull any filled cells