search

jkorell / iperf

Automatically exported from code.google.com/p/iperf
Other
1 stars 0 forks source link

uClibc(old) getopt bug #94

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
under (an old) uClibc on a median-endian ARM:

around src/iperf_api.c : ~440
getopt_long(argc, argv,"p:f:i:DVJdvsc:ub:t:n:l:P:Rw:B:M:N6S:Zh", longopts, NULL)
returns 255 on error (and not -1)

something like this seems safer (wrapping in isascii)
http://lists.uclibc.org/pipermail/uclibc/2006-January/034710.html

I love your tool.
keep the good work.

Original issue reported on code.google.com by stephane...@lip6.fr on 15 Oct 2013 at 1:52

Attachments:

GoogleCodeExporter commented 8 years ago 
Interesting idea!

Original comment by jef.posk...@gmail.com on 15 Oct 2013 at 2:00

GoogleCodeExporter commented 8 years ago 
Jef:

Can you check on this patch, and apply it if you think its good to go?

Original comment by bltier...@es.net on 2 Nov 2013 at 3:14

GoogleCodeExporter commented 8 years ago 
btw: I think issue 78 is related.
https://code.google.com/p/iperf/issues/detail?id=78#c6
(symptoms-at option parsing- and conditions-arm- are very alike)

Original comment by stephane...@lip6.fr on 2 Nov 2013 at 8:52

GoogleCodeExporter commented 8 years ago

Original comment by bltier...@es.net on 9 Nov 2013 at 6:57

GoogleCodeExporter commented 8 years ago 
I did check out this patch. It's an interesting hack to deal with a very old, 
and some would say buggy, version of libc.

It's only a one-line change but it does make that line of code rather less 
clear.

I think unless we have a specific example of a system with this problem, we 
should mark this Won't Fix.

Original comment by jef.posk...@gmail.com on 10 Dec 2013 at 12:39

GoogleCodeExporter commented 8 years ago

Original comment by bltier...@es.net on 18 Dec 2013 at 9:19