paulmillar
commented
5 months ago I agree with @hgoerzig's comments, but personally I don't find NXexperiment or NXinsitu compelling names for the new class. To me, NXexperiement would naturally describe something closer to what is currently NXentry, while the phrase in situ (as in NXinsitu) is more naturally a relationship (describing the relative physical locality of two things) than describing a thing in of itself.
Unfortunately, NXenvironment is already taken (and seemingly describing something that isn't really as environment).
Perhaps the new class could simply be NXsample_environment?
The new example looks pretty good :-) I like the clear separation of the sample environment and the sample. So the technical data and scientific relavant data can be viewed sepreately. I assume the data in sample is created by referencing the data in sample_environment?
For the sample_environment I would suggest not to use NXsample. The scope of NXsample is "Any information on the sample." Perhabs you can create a class called maybe NXexperiment or NXinsitu? The rough definition would be something like apperatus/instrument for conducting an experiment.