search

jkotlinski / durexforth

Modern C64 Forth
Other
233 stars 28 forks source link

Minimum changes for functional split dictionary #279

Closed burnsauce closed 4 years ago

burnsauce commented 4 years ago

Cart does not build, as dictionary is too big.

jkotlinski commented 4 years ago

Thanks, and sorry for the inconvenience! Since this seems an excellent starting point, I think it seems practical to merge these changes to master wholesale. I'll also review these changes, and add comments, and we can create new issues fur further things to investigate. Right now I'm mostly interested in making this work with the minimum amount of new code necessary :) Sounds OK?

burnsauce commented 4 years ago

Sure. This branch is basically where I was minus hide and show. Might be a bug somewhere that was introduced in the rebase, but it seems to work

jkotlinski commented 4 years ago

Hi! Just FYI I am going through things one by one. It takes a bit of time, because I only have free time in the evenings and then I'm a bit tired to think :-) But I'm slowly getting there. Thanks for your patience.

burnsauce commented 4 years ago

No rush. I'm not in any hurry to get this in, I just realized these things as I have been using it the past few days.

jkotlinski commented 4 years ago

I am closing this one since another PR appeared :-) I am moving over my review to the other one.