search

jkotlinski / durexforth

Modern C64 Forth
Other
230 stars 28 forks source link

Minimal Split Dictionary, redux #281

Closed burnsauce closed 3 years ago

burnsauce commented 3 years ago

Here is an even smaller version of the split dictionary changes. It is functional except for the cartridge, which requires 212 bytes to be removed from the dictionary.

I have taken care to try to create the smallest possible set of diffs, hence the least number of changes. There are also changelog and documentation fixes.

I'm not going to close the other one in case you prefer. Again, I am not in a hurry and do not this change in master any time soon.

jkotlinski commented 3 years ago

Great job - approved - added some comments that you can deal with as you feel like :-)

jkotlinski commented 3 years ago

Its not so easy because you want the entire file loaded in one go, for the fastloaders to do its job, and its a bit of work i guess to check in advance if the file will fit in a buffer.

On Wed, 28 Oct 2020 at 19:18, Poindexter Frink notifications@github.com wrote:

@burnsauce commented on this pull request.

In docs/memmap.tex https://github.com/jkotlinski/durexforth/pull/281#discussion_r513665388:

\item[\ldots] \item[\texttt{bufstart} - \texttt{eof}] Editor text buffer. Grows upwards as needed. Default \texttt{bufstart} is \$7000. \item[\ldots] +\item[\texttt{latest @} - \$9fff] Dictionary. Grows downwards as needed.

One more sentinel won't break the bank. ;)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jkotlinski/durexforth/pull/281#discussion_r513665388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34O6U4Z2ZEOZD4GIWNSDSNBOATANCNFSM4TADSNUQ .

burnsauce commented 3 years ago

Its not so easy because you want the entire file loaded in one go, for the fastloaders to do its job, and its a bit of work i guess to check in advance if the file will fit in a buffer.

Well, it's a problem for another day then :)