search

jkotlinski / durexforth

Modern C64 Forth
Other
230 stars 28 forks source link

Fixed EOL and file mode #306

Closed polluks closed 3 years ago

jkotlinski commented 3 years ago

Is there a practical value for you to make these changes? For me personally it is not a problem if linebreaks are not consistent between files. It seems to work fine anyway.

polluks commented 3 years ago

Linebreaks are just for convenience, end of the year clean-up ;-)

jkotlinski commented 3 years ago

I see... well personally the line breaks do not bother me because i never had a problem with that, as far as I could remember. Maybe its different for others? Generally speaking, I’m against ”change every line” kind of changes, because they mess a bit with history and make ”git blame” a little less convenient to work with. But if it makes things more convenient for someone out there, I’m all for it.

I suspect the effort to reformat .tex files to a particular line length is futile. The TeX editors that I tried simply put each paragraph on a very long line. The easy and permanent solution to that behavior is to just accept it :-)

On Wed, 16 Dec 2020 at 23:01, Stefan notifications@github.com wrote:

Linebreaks are just for convenience, end of the year clean-up ;-)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jkotlinski/durexforth/pull/306#issuecomment-747067280, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34OYHTEJZB3AEENUS2UDSVEU45ANCNFSM4U56Y53Q .

burnsauce commented 3 years ago

I'm also against these, they really clutter up the view of the repo and the blame, etc.

jkotlinski commented 3 years ago

Merged! Better have it over with.

jkotlinski commented 3 years ago

OK, I reverted this. The line ending changes caused merge conflicts with other PR's. It is something that could be revisited once there are no big PR's in progress.

jkotlinski commented 3 years ago

It might not be practical to accept the line end changes. The other changes are fine.