jkotlinski / durexforth

Modern C64 Forth
Other
230 stars 28 forks source link

Space after filename or before drive status upon save in V slipped #457

Closed Whammo closed 2 years ago

Whammo commented 2 years ago

saving boo00, ok,00,00

save-v

jkotlinski commented 2 years ago

problem appeared with b5cd7201685eda8702f7d30347616a692519242d

Whammo commented 2 years ago

~I think this may be because v enables Kernal logging before saving, then calls ioabort which uses BASIC logging.~

rom-kernal
page
$9d c@ $ff $9d c! \ kernal log on

\ scratch old file
here
's' over c! 1+
'0' over c! 1+
':' over c! 1+
filename 1+ over filename c@ move
filename c@ + lf swap c!
here filename c@ 4 +
$f $f open ioabort $f close

bufstart eof @
filename count saveb
$9d c! \ restore kernal log
Whammo commented 2 years ago

Leading space before ' ok' is normal. ~though it's the only message that supplies one.~

Whammo commented 2 years ago

v is large enough. Perhaps in saveb disk.asm


    jsr SAVE
    lda $20     ;here
    jsr CHROUT  ;to here
    jsr _errorchread
jkotlinski commented 2 years ago

yes... probably it also makes sense if SAVEB enables & resets kernal logging instead of WRITE-FILE?

Whammo commented 2 years ago

That bell is whistling clearly now. 😃