search

jkotlinski / lsdpack

Standalone LSDj recorder+player
GNU General Public License v2.0
116 stars 18 forks source link

Static noise and flickering #9

Closed rablador closed 3 years ago

rablador commented 3 years ago

Hi!

I get static noise and flickering when following the instructions to compile a .gb rom with the player.s and boot.s (it seems to run "correctly" otherwise). There's no audio in the video below, but unless I'm mistaken the flickering coincides with the noise.

Screen Recording 2020-11-22 at 11.50.37.mov.zip

Unfortunately I don't speak assembly very well, but here's the full set of files used (original lsdj.gb, save, assembly files etc):

flicker_and_static_src.zip

jkotlinski commented 3 years ago

Hi! It's likely because of issue #8 . I should try to fix that.

jkotlinski commented 3 years ago

I pushed a fix to master now, could you tell if it works for you? A word of caution, it will not sound OK on all emulators. But it should be fine in e.g. Gambatte and SameBoy.

rablador commented 3 years ago

It is indeed better, but stills flickers a little. I get the best result with Gambatte, but Sameboy works ok as well. GBA mode i Sameboy sounds weird though, with white noise at the end of the song. Guess it doesn't matter much, but thought I should report since I happened to stumble upon it.

jkotlinski commented 3 years ago

The flicker you notice is normal and indicates varying CPU usage as the song is being played back. The code that draws the bars is intended to be replaced by user :-)

On Sun, 22 Nov 2020 at 16:39, Jon Petersson notifications@github.com wrote:

It is indeed better, but stills flickers a little. I get the best result with Gambatte, but Sameboy works ok as well. GBA mode i Sameboy sounds weird though, with white noise at the end of the song. Guess it doesn't matter much, but thought I should report since I happened to stumble upon it.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/jkotlinski/lsdpack/issues/9#issuecomment-731766294, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34O5WZYHFAKNTJCNX2NTSREWBTANCNFSM4T6NAX4Q .

rablador commented 3 years ago

Ah well, guess I'll have to learn some assembly then. Thanks for the fix! :)

jkotlinski commented 3 years ago

Cool! Let me know if you need any help or pointers!