search

jkotlinski / lsdpatch

LSDj Patcher
http://www.littlesounddj.com
Other
173 stars 14 forks source link

Avoid manual sample conversion #44

Closed jkotlinski closed 4 years ago

jkotlinski commented 4 years ago

For non-technical users, it would be great if sox was run automatically, without any need to prepare samples from the command line.

Eiyeron commented 4 years ago

I don't know how bundling binary executable would work with lsdj.

Looks like there are wrappers that call the executable itself like this library

Regarding filtering or resampling, there are some libraries in java or wrapping libresample to do this kind of process, this might alleviate us from many headaches regarding converting ourselves the sample data.

jkotlinski commented 4 years ago

I don’t exactly know what is possible, but anything that makes this process easier is an improvement :-) Since not everyone knows how to use command line tools.

On Wed, 7 Oct 2020 at 09:55, Florian Dormont notifications@github.com wrote:

I don't know how bundling binary executable would work with lsdj.

Looks like there are wrappers that call the executable itself like this https://github.com/corballis/sox-wrapper-java library

Regarding filtering or resampling, there are some libraries in java or wrapping libresample to do this kind of process, this might alleviate us from many headaches regarding converting ourselves the sample data.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jkotlinski/lsdpatch/issues/44#issuecomment-704763416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34O2E5JVB7A6JKTCJPYLSJQNHXANCNFSM4SGO4AAQ .

jkotlinski commented 4 years ago

Java AudioSystem also has inbuilt facilities for sample conversion. Maybe it would be possible to use that to get to 11468 Hz 8-bit. And then manually dither and convert to 4-bit. I am unsure of quality compared to sox.

On Wed, 7 Oct 2020 at 10:01, Johan Kotlinski kotlinski@gmail.com wrote:

I don’t exactly know what is possible, but anything that makes this process easier is an improvement :-) Since not everyone knows how to use command line tools.

On Wed, 7 Oct 2020 at 09:55, Florian Dormont notifications@github.com wrote:

I don't know how bundling binary executable would work with lsdj.

Looks like there are wrappers that call the executable itself like this https://github.com/corballis/sox-wrapper-java library

Regarding filtering or resampling, there are some libraries in java or wrapping libresample to do this kind of process, this might alleviate us from many headaches regarding converting ourselves the sample data.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jkotlinski/lsdpatch/issues/44#issuecomment-704763416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34O2E5JVB7A6JKTCJPYLSJQNHXANCNFSM4SGO4AAQ .

Eiyeron commented 4 years ago

I tried to use java's built-in solution but I kept having issues with playback, getting samples cut too soon or having a pop at the end. I think I'm going to need to do some detective work to figure what's really happening for that to be so glitchy.

jkotlinski commented 4 years ago

Implemented in Java now.

Eiyeron commented 4 years ago

Ah, great, thanks! How does Java's resampler sound like compared to your handmade solution?

jkotlinski commented 4 years ago

I dont know but its probably better!

On Mon, 12 Oct 2020 at 10:23, Florian Dormont notifications@github.com wrote:

Ah, great, thanks! How does Java's resampler sound like compared to your handmade solution?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jkotlinski/lsdpatch/issues/44#issuecomment-706963892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34O7PDXOFTXCMHTAGWX3SKK4HDANCNFSM4SGO4AAQ .