search

jkotra / unlockr

GNU General Public License v3.0
21 stars 7 forks source link

Added the feature to select the destination folder #15

Closed soumyaDghosh closed 10 months ago

soumyaDghosh commented 10 months ago

Closes #12

jkotra commented 10 months ago

is this complete PR? I don't see any changes in main.c where signal callback needs to be changed. I also expect a overview at end end to display the decryption status of each file in the folder.

Maybe I'm missing something, could you please provide instructions to test the functionality of this PR?

Thanks.

soumyaDghosh commented 10 months ago

I did nothing extra, as I thought your design might not suit it.

What I did was, when the Decrypt button is clicked, I opened a Gtk.FileDialog, where the user will select folder. Then, it'll simply decrypt to that folder and show it to the user.

Screencast from 2023-10-10 14-03-14.webm

jkotra commented 10 months ago

I did nothing extra, as I thought your design might not suit it.

What I did was, when the Decrypt button is clicked, I opened a Gtk.FileDialog, where the user will select folder. Then, it'll simply decrypt to that folder and show it to the user. Screencast.from.2023-10-10.14-03-14.webm

Thanks!

I understand your work now. will get back to you soon with suggestions (if any).

Regards.

soumyaDghosh commented 10 months ago

@jkotra any way to connect with you personally?

jkotra commented 10 months ago

closed in favor of #16. my PR implements menu option to toggle save to folder option and tricky windows integration. I think it goes without saying that default behavior should not be changed. Appreciate your effort though, Thanks.

jkotra commented 10 months ago

@jkotra any way to connect with you personally?

you can contact me at jagadeesh@stdin.top.