search

jkotra / unlockr

GNU General Public License v3.0
21 stars 7 forks source link

Error handle for null folder #17

Closed soumyaDghosh closed 10 months ago

soumyaDghosh commented 10 months ago

Hii, I just tested your implementation, the problem is, there is no way for error handling for not choosing a folder, like I did in my one. And I must say, this implementation really doesn't look good. None will be able to know that you select the save folder, unless you click on the hamburger menu. Kindly look into these. Do you really think this is a better implementation?

jkotra commented 10 months ago

Thanks for the bug report, i have released a hot fix - 0.9.1

None will be able to know that you select the save folder, unless you click on the hamburger menu.

While the option was not really explicit in UI, someone who is looking for it will be able to find it. Also, i think it's more inline with gnome HIG.

soumyaDghosh commented 10 months ago

While the option was not really explicit in UI, someone who is looking for it will be able to find it. Also, i think it's more inline with gnome HIG.

Ummm... Not sure about Gnome HIG and these things. It's your design choice. So, closing this as completed.