search

jkovacs / lastfm-java

Java bindings for the Last.fm Web Services
BSD 2-Clause "Simplified" License
74 stars 34 forks source link

Normalized Line Endings #2

Closed pfdevmuller closed 9 years ago

pfdevmuller commented 10 years ago

Hi Janni I've normalizes the line endings of my fork, according to the recommendations given here: https://help.github.com/articles/dealing-with-line-endings

The summary is that git recommends storing files in the repo with unix/mac style line endings (just a LF, not LFCR) The Windows git client can easily be configured to convert line endings to LF on commit and convert to LFCR on checkout, making the difference transparent to the user. From what I could tell, the same is not true of the unix/mac client, so I had to convert my line endings to save myself a lot of effort.

I've committed the change and you are more than welcome to merge it in - I definitely recommend normalizing your repo's line endings. However, the draw back of merging my change in is that I will be the last commit author for every line of code in the library. If this bothers you, you could do it yourself and I'll resync off your repo. It takes about 10 minutes to do the normalization by following the steps in the website I linked above.

Cheers Pieter

jkovacs commented 9 years ago

Oh dear, only now, because of Google Code's closure, did I notice that this PR still wasn't closed, I apologize greatly, merging this now...