jkpang / PPBadgeView

iOS Custom Badge, Support UIView, UITabBarItem, UIBarButtonItem ,Support Objective-C/Swift; iOS自定义Badge组件, 支持UIView, UITabBarItem, UIBarButtonItem, 支持Objective-C/Swift
MIT License
848 stars 118 forks source link

swift版本兼容 #14

Closed youlianchun closed 6 years ago

youlianchun commented 6 years ago

啥时候进行版本迁移? 'Self' is only available in a protocol or as the result of a method in a class;

jkpang commented 6 years ago

你使用的Swift是什么版本,PPBadgeViewSwift 2.1.0在Swift 4.1环境下编译没有问题 @youlianchun

youlianchun commented 6 years ago

最新的,xcode10下,应该是swift4.2

jlaws commented 6 years ago

XCode 10 support requires line 36 of PPBadgeLabel to add the required keyword. Can we get an updated podspec with the fix now that the Xcode 10 GM is out? Thanks for the great library!

damozhang commented 6 years ago

@jlaws I have submit a pull request #15

jkpang commented 6 years ago

PPBadgeViewSwift release v2.2.0, support Xcode10 and Swift4.2,Thanks for feedback! @jlaws @youlianchun

Thanks @12789 for pull request.

image