Open peteobrien opened 10 years ago
Hey @peterobrien,
I think you got some mess in your configuration ... just a few hints to get you going:
options
object needs to look similar to here.render
option needs to be an object, not a string. The keys this object is holding define which output formats will be rendered, the values are rendering parameters (like e.g. the template to be used)Good luck! Cheers, Joschi
Thanks for the hints Joschi. Unfortunately I still can't seem to get it to generate sprite.inline.svg
nor the generated html example of using inline.
Are the defs added by the iconzr/svg-sprite generator? I assumed they get added by the generator but since no sign of them I've tried adding them to individual svgs but the ids get removed from the containiner g element anyway.
If you could highlight any error in the below configuration that'd be much appreciated (I have read the links you mentioned above but can't see the mistake)
iconizr: {
your_target: {
src: 'src/svg',
dest: 'src/iconizr-output',
options: {
render: {
'inline.svg': true,
html: true
},
},
},
},
Thanks, Peter
I've uploaded a super simple test case to here https://github.com/peterobrien/InlineSvgViaGruntIconizrTestcase.git and added the grunt-iconizr generated assets. Is it something simple I'm missing?
Hi @peterobrien,
due to MASSIVE workload I will not be able to respond at least until end of this week, sorry. Please hold on!
Cheers, Joschi
Thanks Joschi, hope the week's work goes well. Appreciate your efforts with this project.
Hi Joschi, not sure how your workload is but if you have a min to have a look at this would be grateful.
Thanks, Peter
I'm experiencing this bug too.. I can't get the inline svgs working at all.
Hi @peterobrien, hi @Ramblurr,
I'm sorry but my workload is still extreme. I'm organizing 2 events next week, including a 2-day conference, I'm hardly sleeping these days and this won't change for another 2 weeks I guess. I'm afraid I won't have time for working on any of my side projects until the end of this month.
On the other hand, this is also a contribution platform — maybe anyone else up for looking into this in the meantime?
Cheers, Joschi
Cheers Joschi. If I've the time will take a look myself although am short on it also (young children, work etc) and haven't written any node modules either so will require a bit of learning too.
That conference you're organizing looks very cool. Good luck with it!
Thanks for your understanding, @peterobrien!
Of course @jkphl, this plugin is great. Maybe you should reopen the issue though.
Hi @peterobrien & @Ramblurr,
just wanted to let you know that I'll start rewriting iconizr from scratch in the next couple of days. I released an all-new version of svg-sprite a couple of days ago, which is the base of iconizr and supports several inline sprite variants now. Please stay tuned, this might (and hopefully will) solve your problems.
Besides that, Happy New Year! :)
Cheers, Joschi
Probably something stupid I'm doing but what should the value of
render
option be to get inline svg? I can't seem to generatesprite.inline.svg
Nor when specifyinghtml:true
am I getting anysprite.html
. have tried a mixture of things but not getting it working yetIn case it's related in the
sprite-preview.html
generated, the icons don't appear (but in the other preview files they do) .