jkphl / iconizr

A PHP command line tool for converting SVG images to a set of CSS icons (SVG & PNG, single icons and / or CSS sprites) with support for image optimization and Sass output. Created by Joschi Kuphal (@jkphl), licensed under the terms of the MIT license
http://iconizr.com
MIT License
485 stars 36 forks source link

Drop the `width` and `height` options #17

Open jkphl opened 10 years ago

jkphl commented 10 years ago

The width and height options, which are meant for SVG images that lack proper dimension settings, are somewhat useless. Applying fixed values for missing properties will always result in distorted images. Nobody wants that. Instead, the real image dimensions should be determined by test rendering the SVG via PhantomJS (like done in svg-sprite). The two options are therefore obsolete and should be removed.