jkphl / micrometa

A meta parser for extracting micro information out of web documents, currently supporting Microformats 1+2, HTML Microdata, RDFa Lite 1.1, JSON-LD and Link Types, written in PHP
http://micrometa.jkphl.is
MIT License
115 stars 39 forks source link

PHP 8 Support #64

Closed blankse closed 3 years ago

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.01%) to 99.284% when pulling 0eaf9245148a63e208368ff951f0dab0639010c8 on blankse:php8 into c1536f66f4f8964018c061c1d61279c10d2724f8 on jkphl:master.

jkphl commented 3 years ago

Same here, trying to get this merged on the weekend

blankse commented 3 years ago

Dependency "clue/graph-composer" doesn't seem ready for 8.0 :(

jkphl commented 3 years ago

@blankse Unfortunately, simply removing clue/graph-composer is not an option for me. Need to get that PHP8 ready first.

blankse commented 3 years ago

@jkphl With the original clue/graph-composer it can be installed. Is this enough?

jkphl commented 3 years ago

@blankse Great news — that's a good start, yes. However, the one feature I added was the ability to skip development dependencies (or to only list development dependencies), as far as I remember. See https://github.com/clue/graph-composer/commit/28466d158dc678b946c757be129526cbf05ad3d7 and https://github.com/clue/graph-composer/commit/dff4bac16484fa429d6157e89118e922264323b5. We'd have to re-implement these features in order to move forward. Unfortunately, I won't have the capacity to do that anytime soon. Would you be able to step in here?

rvanlaak commented 3 years ago

If I'm correct clue/graph-composer is not a runtime dependency, but a "tool dependency" ?

Can we find a way to exclude this dependency from being a requirement for using micrometa in runtime? e.g. by running the clue/graph-composer via a Makefile task?

blankse commented 3 years ago

@jkphl I merged the original repository in your fork. See https://github.com/jkphl/graph-composer/pull/1 When you can merge this. I can change it back to your fork.

blankse commented 3 years ago

Ping @jkphl

blankse commented 3 years ago

@rvanlaak Can you create a release tag with this change?

rvanlaak commented 3 years ago

v3.1.0 just has been released

blankse commented 3 years ago

@rvanlaak Thank you 👍🏼