search

jkraemer / mail-gpg

GPG/MIME extension for the Ruby Mail Library
MIT License
69 stars 24 forks source link

Fix double-decoding QP. #57

Closed duckdalbe closed 6 years ago

duckdalbe commented 6 years ago

The code copies all email-headers unchanged and unfiltered, so it must copy the body unchanged, too.

Otherwise a double-decoding of the body will occur, which leads to stripped trailing equal-signs (because they are considered "soft line breaks" in compliance with RFC 2045, Section 6.7, paragraph 5).

duckdalbe commented 6 years ago

ping.

I don't know what makes travis fail all the jobs for this PR (https://travis-ci.org/jkraemer/mail-gpg/builds/337298149) but to me it looks like my code-changes are not the problem. Am I right? Otherwise please tell me!

EDIT: Locally the tests all run green.

jkraemer commented 6 years ago

Thanks and sorry for the delay. Re travis - the pass phrase setting does not seem to work in this environment, thats why it always fails.

geor-g commented 6 years ago

Could this go into a release, soon?

geor-g commented 6 years ago

Ping...

jkraemer commented 6 years ago

Done :)

geor-g commented 6 years ago

Yeah, thank you! :)