search

jkraemer / mail-gpg

GPG/MIME extension for the Ruby Mail Library
MIT License
69 stars 24 forks source link

Debian / ruby2.5 / mail-gpg 0.3.2: Failing tests #59

Closed geor-g closed 6 years ago

geor-g commented 6 years ago

Hi,

While importing the last release into Debian, I did run into the following, which blocks the upload currently:

Loaded suite /usr/lib/ruby/vendor_ruby/rake/rake_test_loader
Started
DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job. (called from block (3 levels) in <class:ActionMailerTest> at /<<PKGBUILDDIR>>/test/action_mailer_test.rb:117)
.DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job. (called from block (3 levels) in <class:ActionMailerTest> at /<<PKGBUILDDIR>>/test/action_mailer_test.rb:89)
/<<PKGBUILDDIR>>/lib/mail/gpg/message_patch.rb:41: warning: instance variable @gpg not initialized
.DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job. (called from block (3 levels) in <class:ActionMailerTest> at /<<PKGBUILDDIR>>/test/action_mailer_test.rb:102)
.DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job. (called from block (3 levels) in <class:ActionMailerTest> at /<<PKGBUILDDIR>>/test/action_mailer_test.rb:53)
.DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job. (called from block (3 levels) in <class:ActionMailerTest> at /<<PKGBUILDDIR>>/test/action_mailer_test.rb:67)
.DEPRECATION WARNING: `#deliver` is deprecated and will be removed in Rails 5. Use `#deliver_now` to deliver immediately or `#deliver_later` to deliver through Active Job. (called from block (3 levels) in <class:ActionMailerTest> at /<<PKGBUILDDIR>>/test/action_mailer_test.rb:43)
/<<PKGBUILDDIR>>/lib/mail/gpg/message_patch.rb:41: warning: instance variable @gpg not initialized
.E
===============================================================================
Error: test: DecryptedPart should decrypt and verify. (DecryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/decrypted_part_test.rb:14:in `new'
/<<PKGBUILDDIR>>/test/decrypted_part_test.rb:14:in `block (2 levels) in <class:DecryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: DecryptedPart should decrypt. (DecryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/decrypted_part_test.rb:14:in `new'
/<<PKGBUILDDIR>>/test/decrypted_part_test.rb:14:in `block (2 levels) in <class:DecryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: DecryptedPart should raise encoding error for non gpg mime type. (DecryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/decrypted_part_test.rb:14:in `new'
/<<PKGBUILDDIR>>/test/decrypted_part_test.rb:14:in `block (2 levels) in <class:DecryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with email address should resolve email to gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with email address should resolve emails to gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with emails and key data should resolve to gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with key fingerprint should resolve id list to gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with key fingerprint should resolve single id  gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with key id should resolve id list to gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
E
===============================================================================
Error: test: EncryptedPart with key id should resolve single id  gpg keys. (EncryptedPartTest): NoMethodError: undefined method `size' for nil:NilClass
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:132:in `keys_for_data'                                                                                                                                                                                                                                                                                                                                                                     
/<<PKGBUILDDIR>>/lib/mail/gpg/gpgme_helper.rb:14:in `encrypt'
/<<PKGBUILDDIR>>/lib/mail/gpg/encrypted_part.rb:20:in `initialize'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `new'
/<<PKGBUILDDIR>>/test/encrypted_part_test.rb:20:in `block (2 levels) in <class:EncryptedPartTest>'
===============================================================================
......................................................../<<PKGBUILDDIR>>/lib/mail/gpg/verify_result_attribute.rb:10: warning: instance variable @verify_result not initialized
.......................
.........

Finished in 25.665790299 seconds.
------
104 tests, 471 assertions, 0 failures, 10 errors, 0 pendings, 0 omissions, 0 notifications
90.3846% passed
------
4.05 tests/s, 18.35 assertions/s
rake aborted!

Please note: Debian switched recently to ruby2.5, not sure if this could be related. Also, the deprecation warnings aren't a problem (currently), I'm more afraid of the failing tests. Any advice regarding this?

Thanks for your work, cheers, Georg

jkraemer commented 6 years ago

Thank you, I indeed messed that up, these errors are totally unrelated to Ruby 2.5. My local testing environment is currently broken for the same reasons travis CI isn't working right now, making my workflow a bit complicated. I just pushed out 0.3.3

geor-g commented 6 years ago

Thanks a lot, highly appreciated, works! :) Upload upcoming...