search

jkraemer / pdf-forms

Fill out PDF forms with pdftk (http://www.accesspdf.com/pdftk/).
MIT License
287 stars 73 forks source link

some tests failing (ruby 2.5.1 / macos 10.13 / pdftk 2.02) #69

Closed drnic closed 6 years ago

drnic commented 6 years ago 
$ ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
$ pdftk --version
pdftk 2.02 a Handy Tool for Manipulating PDF Documents

$ bundle exec rake
/Users/drnic/.rvm/rubies/ruby-2.5.1/bin/ruby -I"lib:lib:test" -I"/Users/drnic/.rvm/gems/ruby-2.5.1/gems/rake-10.5.0/lib" "/Users/drnic/.rvm/gems/ruby-2.5.1/gems/rake-10.5.0/lib/rake/rake_test_loader.rb" "test/**/*_test.rb"
Run options: --seed 28636

# Running:

..................F...........F....................

Finished in 17.399337s, 2.9311 runs/s, 6.9543 assertions/s.

  1) Failure:
PdftkWrapperTest#test_fill_form_and_encrypt_for_opening [/Users/drnic/Projects/rubygems/pdf-forms/test/pdftk_wrapper_test.rb:74]:
Expected /OWNER OR USER PASSWORD REQUIRED/ to match "Error: Failed to open PDF file: \n   output.pdf\n   OWNER PASSWORD REQUIRED, but not given (or incorrect)\nDone.  Input errors, so no output created.\n".

  2) Failure:
XfdfPdftkWrapperTest#test_fill_form_and_encrypt_for_opening [/Users/drnic/Projects/rubygems/pdf-forms/test/pdftk_wrapper_test.rb:74]:
Expected /OWNER OR USER PASSWORD REQUIRED/ to match "Error: Failed to open PDF file: \n   output.pdf\n   OWNER PASSWORD REQUIRED, but not given (or incorrect)\nDone.  Input errors, so no output created.\n".

51 runs, 121 assertions, 2 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -I"lib:lib:test" -I"/Users/drnic/.rvm/gems/ruby-2.5.1/gems/rake-10.5.0/lib" "/Users/drnic/.rvm/gems/ruby-2.5.1/gems/rake-10.5.0/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" ]
jkraemer commented 6 years ago

That's interesting. I have the exact same versions of Ruby and pftk, but running on Linux, and all is green.

Looks like the pdftk error message when encountering an encrypted document is different on the Mac. I think it's safe to simply relax the regular expression in the test.